Rafael Diniz has posted comments on this change. ( https://gerrit.osmocom.org/12718 )
Change subject: Added support for daemonize to osmo-pcu. ...................................................................... Patch Set 1: (1 comment) > > Patch Set 1: Code-Review+2 > > Wait, wait, I don't see that all comments were addressed. Why CR+2? Sorry, never used this before. Bumped a button by accident. https://gerrit.osmocom.org/#/c/12718/1/src/pcu_main.cpp File src/pcu_main.cpp: https://gerrit.osmocom.org/#/c/12718/1/src/pcu_main.cpp@63 PS1, Line 63: static int daemonize = 0; > If it's only used as true/false than please use bool for type to reflect that. I just copied the way osmo-mgw does, and in there it uses int. Can I use C99 bool? -- To view, visit https://gerrit.osmocom.org/12718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia889544e0a350b6bab55da4e4201a617e0241ea2 Gerrit-Change-Number: 12718 Gerrit-PatchSet: 1 Gerrit-Owner: Rafael Diniz <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Rafael Diniz <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Keith Whyte <[email protected]> Gerrit-Comment-Date: Tue, 29 Jan 2019 14:27:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
