Max has posted comments on this change. ( https://gerrit.osmocom.org/12718 )
Change subject: Added support for daemonize to osmo-pcu. ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12718/1/src/pcu_main.cpp File src/pcu_main.cpp: https://gerrit.osmocom.org/#/c/12718/1/src/pcu_main.cpp@63 PS1, Line 63: static int daemonize = 0; > I just copied the way osmo-mgw does, and in there it uses int. […] Sure, if you do 'git grep -n bool' you'll see that it's actively used already in many places. -- To view, visit https://gerrit.osmocom.org/12718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia889544e0a350b6bab55da4e4201a617e0241ea2 Gerrit-Change-Number: 12718 Gerrit-PatchSet: 1 Gerrit-Owner: Rafael Diniz <raf...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Rafael Diniz <raf...@rhizomatica.org> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-CC: Keith Whyte <ke...@rhizomatica.org> Gerrit-Comment-Date: Tue, 29 Jan 2019 14:32:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No