osmith has posted comments on this change. ( https://gerrit.osmocom.org/12837 )
Change subject: Add stream client/server test ...................................................................... Patch Set 3: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.c File tests/stream/stream_test.c: https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.c@15 PS2, Line 15: #include <errno.h> Is errno.h used? https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.c@175 PS2, Line 175: Should this be 127.0.0.1? If not, please explain. https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.ok File tests/stream/stream_test.ok: https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.ok@54 PS2, Line 54: Test step 3 [client OK, server NA] The step output is a bit weird, because it is counting steps down and then stops at 3. How about the classic step 1, 2, 3, ...? Or what's the advantage of having it implemented like it is now? -- To view, visit https://gerrit.osmocom.org/12837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e Gerrit-Change-Number: 12837 Gerrit-PatchSet: 3 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Tue, 05 Feb 2019 15:55:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
