Max has posted comments on this change. ( https://gerrit.osmocom.org/12837 )
Change subject: Add stream client/server test ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.ok File tests/stream/stream_test.ok: https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.ok@54 PS2, Line 54: Test step 3 [client OK, server NA] > The step output is a bit weird, because it is counting steps down and then > stops at 3. […] Counting down to 0 guarantees that the test will terminate in no longer than 'steps' iterations regardless of potential issues with callbacks or other functions. Stopping at 3 (pretty arbitrary number actually) ensures that that test terminated as expected vs via safeguard above. -- To view, visit https://gerrit.osmocom.org/12837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e Gerrit-Change-Number: 12837 Gerrit-PatchSet: 3 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Tue, 05 Feb 2019 16:02:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
