osmith has posted comments on this change. ( https://gerrit.osmocom.org/12857 )
Change subject: Add timeout wrapper to regular gerrit verification jobs ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/12857/1/jobs/gerrit-verifications.yml File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/#/c/12857/1/jobs/gerrit-verifications.yml@23 PS1, Line 23: 15m How about we put the 15m into a variable at the top, that can be overridden by each job? Then we could easily change the default if necessary. I wasn't sure if 15 minutes is a good default btw, but looking at https://jenkins.osmocom.org/jenkins/view/gerrit/ and sorting by last duration, the longest job takes 11 minutes currently. So it seems to be a sane choice. https://gerrit.osmocom.org/#/c/12857/1/jobs/gerrit-verifications.yml@43 PS1, Line 43: osmocom:amd64 /build/contrib/jenkins.sh I would suggest to add this line to the Docker jobs, too. You can add it like this: osmocom:amd64 timeout 15m /build/contrib/jenkins.sh -- To view, visit https://gerrit.osmocom.org/12857 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d0eb6b9eddf3e17120e74d7570d42291c0750ae Gerrit-Change-Number: 12857 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Fri, 08 Feb 2019 09:49:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
