osmith has posted comments on this change. ( https://gerrit.osmocom.org/12857 )
Change subject: Add timeout wrapper to regular gerrit verification jobs ...................................................................... Patch Set 2: Code-Review+1 (1 comment) FYI: the configs do *not* get automatically updated after this gets merged. So you need to manually run "jenkins-jobs update" afterwards. https://gerrit.osmocom.org/#/c/12857/1/jobs/gerrit-verifications.yml File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/#/c/12857/1/jobs/gerrit-verifications.yml@23 PS1, Line 23: als > when shall we use '{obj:var}' instead of '{var}'? "If you want to pass an object (boolean, list or dict)", as the docs say. So in this case we have a string, not what they define as an object, so "obj:" is not needed. https://jenkins-job-builder.readthedocs.io/en/latest/definition.html#variable-references > Please double-check. Seems to work as expected. I have overwritten the timeout value like this and ran "jenkins-jobs test", then had overwritten the default as expected. - openbsc: job_timeout: 1337m -- To view, visit https://gerrit.osmocom.org/12857 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d0eb6b9eddf3e17120e74d7570d42291c0750ae Gerrit-Change-Number: 12857 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Mon, 11 Feb 2019 15:38:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
