osmith has posted comments on this change. ( https://gerrit.osmocom.org/12845 )
Change subject: Deprecate osmo_stream_cli_open2() ...................................................................... Patch Set 6: Code-Review-1 (2 comments) Code looks good, just some formatting things. https://gerrit.osmocom.org/#/c/12845/6/include/osmocom/netif/stream.h File include/osmocom/netif/stream.h: https://gerrit.osmocom.org/#/c/12845/6/include/osmocom/netif/stream.h@74 PS6, Line 74: int osmo_stream_cli_open2(struct osmo_stream_cli *cli, int reconnect) OSMO_DEPRECATED("Use osmo_stream_cli_set_reconnect_timeout() or osmo_stream_cli_reconnect() instead"); line too long https://gerrit.osmocom.org/#/c/12845/6/tests/stream/stream_test.c File tests/stream/stream_test.c: https://gerrit.osmocom.org/#/c/12845/6/tests/stream/stream_test.c@197 PS6, Line 197: */ This is probably just a matter of taste, and I am not sure how this is usually handled in the Osmocom code base. But I would have placed that whole comment block in a file in doc/ and referenced it below. Then people can read it if they are interested, but it keeps a big chunk of dead code out of this c file. -- To view, visit https://gerrit.osmocom.org/12845 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id988ed0274b363db049f59cbf6a193727c8c3c8a Gerrit-Change-Number: 12845 Gerrit-PatchSet: 6 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Fri, 08 Feb 2019 10:15:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
