Max has posted comments on this change. ( https://gerrit.osmocom.org/12845 )
Change subject: Deprecate osmo_stream_cli_open2() ...................................................................... Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/12845/6/tests/stream/stream_test.c File tests/stream/stream_test.c: https://gerrit.osmocom.org/#/c/12845/6/tests/stream/stream_test.c@197 PS6, Line 197: */ > This is probably just a matter of taste, and I am not sure how this is > usually handled in the Osmoco […] I'd rather keep it here and remove it together with the deprecated function in one of the future releases. -- To view, visit https://gerrit.osmocom.org/12845 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id988ed0274b363db049f59cbf6a193727c8c3c8a Gerrit-Change-Number: 12845 Gerrit-PatchSet: 7 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Tue, 12 Feb 2019 16:50:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
