Max has posted comments on this change. ( https://gerrit.osmocom.org/12867 )
Change subject: WIP: send proper OML alert in case of errors ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12867/1/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/#/c/12867/1/src/common/oml.c@1463 PS1, Line 1463: "unknown O&M msg_disc 0x%02x\n", oh->mdisc); While at it, might be good idea to change this to "unhandled": we certainly know more than ABIS_OM_MDISC_* in libosmocore, we just don't handle them in here. -- To view, visit https://gerrit.osmocom.org/12867 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b19b82a4874617c7c584cf3eac55eb9c756710a Gerrit-Change-Number: 12867 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Max <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 12 Feb 2019 11:43:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
