Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12867 )
Change subject: OML: send proper OML alerts in case of errors ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12867/2/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/#/c/12867/2/src/common/oml.c@1381 PS2, Line 1381: oml_tx_failure_event_rep(&bts->mo, OSMO_EVT_MAJ_UKWN_MSG, Without looking much around this code, one question: Why do you check for trx->mo existance and use it at the end of the function (1418) but for instance not in this line (where alays bts->mo is used)? -- To view, visit https://gerrit.osmocom.org/12867 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b19b82a4874617c7c584cf3eac55eb9c756710a Gerrit-Change-Number: 12867 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Max <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 12 Feb 2019 19:49:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
