Max has posted comments on this change. ( https://gerrit.osmocom.org/12897 )
Change subject: Add multipatch capability to osmo-config-merge ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12897/3/utils/osmo-config-merge.c File utils/osmo-config-merge.c: https://gerrit.osmocom.org/#/c/12897/3/utils/osmo-config-merge.c@267 PS3, Line 267: return 3; > Yes, but ASAN won't be happy. What exactly makes you think that? Those are already build with sanitizer enabled by jenkins and it passes just fine. You can also manually enable it via './configure --enable-sanitize' as well. > let's free stuff as soon as not needed anymore, instead of assuming talloc > will release it at some point in the future. Memory will be freed immediately after that 'return' call. Which "some point in the future" are you talking about? -- To view, visit https://gerrit.osmocom.org/12897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I212cbdc3bf6f251c1a3175737ac74242fb004c6d Gerrit-Change-Number: 12897 Gerrit-PatchSet: 3 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 18 Feb 2019 11:31:17 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
