Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12897 )

Change subject: Add multipatch capability to osmo-config-merge
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/12897/3/utils/osmo-config-merge.c
File utils/osmo-config-merge.c:

https://gerrit.osmocom.org/#/c/12897/3/utils/osmo-config-merge.c@267
PS3, Line 267: return 3;
> > Yes, but ASAN won't be happy.  […]
Please simply add the talloc_free(ctx) to the return-path, like the other 
return paths have it.



--
To view, visit https://gerrit.osmocom.org/12897
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I212cbdc3bf6f251c1a3175737ac74242fb004c6d
Gerrit-Change-Number: 12897
Gerrit-PatchSet: 3
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-CC: Pau Espin Pedrol <[email protected]>
Gerrit-Comment-Date: Mon, 18 Feb 2019 13:21:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to