osmith has posted comments on this change. ( https://gerrit.osmocom.org/12992 )

Change subject: Update config example
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12992/2/doc/examples/osmo-sysmon.cfg
File doc/examples/osmo-sysmon.cfg:

https://gerrit.osmocom.org/#/c/12992/2/doc/examples/osmo-sysmon.cfg@14
PS2, Line 14: example.com
Is there any downside if we comment out that line by default?

It would be unexpected for me from a user's perspective, if I ran the example 
config, and it started pinging a random server on the Internet. That's why I 
recommended a domain that will never resolve in my comment on the first patch 
set.

(With that being said, I don't really know how to use osmo-sysmon - there seems 
to be no README/wiki page/pdf docs about it yet.)



--
To view, visit https://gerrit.osmocom.org/12992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78025027d48a1213b2a23252c8261d9cb4564027
Gerrit-Change-Number: 12992
Gerrit-PatchSet: 2
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Comment-Date: Fri, 22 Feb 2019 10:00:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to