daniel has posted comments on this change. ( https://gerrit.osmocom.org/12992 )
Change subject: Update config example ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12992/2/doc/examples/osmo-sysmon.cfg File doc/examples/osmo-sysmon.cfg: https://gerrit.osmocom.org/#/c/12992/2/doc/examples/osmo-sysmon.cfg@14 PS2, Line 14: example.com > Is there any downside if we comment out that line by default? […] I'm on the fence on this one. On one hand example.com does resolve and ping, so we can tell that we have a connection to the internet. On the other hand the example should choose sane defaults that work for most people and I would guess most would want to change this line. So having it commented out would be good - I'd rather not have an (active) ping in here that doesn't even resolve. -- To view, visit https://gerrit.osmocom.org/12992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78025027d48a1213b2a23252c8261d9cb4564027 Gerrit-Change-Number: 12992 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Fri, 22 Feb 2019 12:16:10 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
