Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13004 )
Change subject: gsm0808: make msgb size and headroom configurable ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13004/1/include/osmocom/gsm/gsm0808.h File include/osmocom/gsm/gsm0808.h: https://gerrit.osmocom.org/#/c/13004/1/include/osmocom/gsm/gsm0808.h@37 PS1, Line 37: #define BSSMAP_MSG_SIZE (osmo_gsm0808_msg_size ? : BSSMAP_MSG_DEFAULT_SIZE - BSSMAP_MSG_DEFAULT_HEADROOM + BSSMAP_MSG_HEADROOM) > I don't really understand what you are trying to do here. […] this weirdness comes from the weirdness of msgb_alloc_headroom() that includes the headroom in the msg size; and from the previous #defines doing the same. What I want to do here is to change headroom independently from the remaining message size, maybe a bad idea to change the semantics indeed -- To view, visit https://gerrit.osmocom.org/13004 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95729991eb49555f8bba60c5dc916131b03b6cf2 Gerrit-Change-Number: 13004 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Sat, 23 Feb 2019 18:11:30 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
