Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13004 )
Change subject: gsm0808: make msgb size and headroom configurable ...................................................................... Patch Set 1: > make the #define depend on sizeof(osmo_prim)? Actually doesn't work: it would need to be struct osmo_scu_prim, which is defined in libosmo-sccp's sccp_sap.h. I still kind of prefer a way where we can use libosmocore for any headroom size any gsm0808 user might need, instead of picking a constant that's hopefully enough... -- To view, visit https://gerrit.osmocom.org/13004 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95729991eb49555f8bba60c5dc916131b03b6cf2 Gerrit-Change-Number: 13004 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Sat, 23 Feb 2019 19:12:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
