osmith has posted comments on this change. ( https://gerrit.osmocom.org/13108 )
Change subject: net/: refactor cfg templates ...................................................................... Patch Set 2: Code-Review-1 (1 comment) This patch does too many things at once, therefore it is hard to review. Gerrit doesn't even show diffs for most files that have been moved. How about one patch per change as usually, or at the very least one extra commit for moving the files? https://gerrit.osmocom.org/#/c/13108/2/net/templates/run.sh File net/templates/run.sh: https://gerrit.osmocom.org/#/c/13108/2/net/templates/run.sh@80 PS2, Line 80: if [ "x${MSC_MNCC}" != "xinternal" ]; then The s/SIPCON_ENABLE/MSC_MNCC/g change should go into its own commit, it is not even mentioned in the commit message. -- To view, visit https://gerrit.osmocom.org/13108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6352c584c0fce57c617387160c285abf40a5f90 Gerrit-Change-Number: 13108 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Mon, 04 Mar 2019 10:06:17 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
