osmith has posted comments on this change. ( https://gerrit.osmocom.org/13108 )
Change subject: net/: refactor cfg templates ...................................................................... Patch Set 3: Code-Review-1 (4 comments) As discussed, let's not split these patches up. Here are some minor things I found, other than that it can be merged in my opinion. https://gerrit.osmocom.org/#/c/13108/3/net/templates/common_template_warning File net/templates/common_template_warning: https://gerrit.osmocom.org/#/c/13108/3/net/templates/common_template_warning@3 PS3, Line 3: # See /etc/osmocom/README I think that line only made sense during CCC https://gerrit.osmocom.org/#/c/13108/3/net/templates/osmo-gbproxy.cfg File net/templates/osmo-gbproxy.cfg: https://gerrit.osmocom.org/#/c/13108/3/net/templates/osmo-gbproxy.cfg@11 PS3, Line 11: timer tns-reset 3 missing ${include(common_template_warning)} on top https://gerrit.osmocom.org/#/c/13108/3/net/templates/osmo-hlr.cfg File net/templates/osmo-hlr.cfg: https://gerrit.osmocom.org/#/c/13108/3/net/templates/osmo-hlr.cfg@9 PS3, Line 9: " store-imei" got lost https://gerrit.osmocom.org/#/c/13108/3/net/templates/osmo-msc.cfg File net/templates/osmo-msc.cfg: https://gerrit.osmocom.org/#/c/13108/3/net/templates/osmo-msc.cfg@11 PS3, Line 11: mncc ${MSC_MNCC} " check-imei-rqd 1" got lost here -- To view, visit https://gerrit.osmocom.org/13108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6352c584c0fce57c617387160c285abf40a5f90 Gerrit-Change-Number: 13108 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Thu, 07 Mar 2019 14:31:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
