Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13133 )
Change subject: encoding: Fixes TMSI vs MI bit selection in repeated page info ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13133/1/src/encoding.cpp File src/encoding.cpp: https://gerrit.osmocom.org/#/c/13133/1/src/encoding.cpp@1098 PS1, Line 1098: while (len) { > iiuc when identity[0] & 0x07) == 4, then necessarily len = 32, would be nice > to add an ASSERT or som […] Probably not an ASSERT as this is outside data (even if just the pcu sock). We don't want to bring down the whole bts in that case, do we? Should we output a LOGL_ERROR and cap len to 4? -- To view, visit https://gerrit.osmocom.org/13133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb00b9133f523f4ba09c8f1fc5694e62dc46fbf Gerrit-Change-Number: 13133 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Willmann <[email protected]> Gerrit-Reviewer: Daniel Willmann <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Omar Ramadan <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 18:48:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
