Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13133 )
Change subject: encoding: Fixes TMSI vs MI bit selection in repeated page info
......................................................................
encoding: Fixes TMSI vs MI bit selection in repeated page info
Change-Id: Iddb00b9133f523f4ba09c8f1fc5694e62dc46fbf
---
M src/encoding.cpp
1 file changed, 15 insertions(+), 1 deletion(-)
Approvals:
Harald Welte: Looks good to me, but someone else must approve
Max: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/encoding.cpp b/src/encoding.cpp
index 4c8cdb0..019de52 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -1066,6 +1066,20 @@
return wp;
}
+/* 3GPP TS 44.060 ยง 11.2.10:
+ < Repeated Page info struct > ::=
+ { 0 -- Page request for TBF establishment
+ { 0 < PTMSI : bit (32) >
+ | 1 < Length of Mobile Identity contents : bit (4) >
+ < Mobile Identity : octet (val (Length of Mobile Identity contents)) >
}
+ | 1 -- Page request for RR conn. establishment
+ { 0 < TMSI : bit (32) >
+ | 1 < Length of Mobile Identity contents : bit (4) >
+ < Mobile Identity : octet (val (Length of Mobile Identity contents)) >
}
+ < CHANNEL_NEEDED : bit (2) >
+ { 0 | 1 < eMLPP_PRIORITY : bit (3) > }
+ }
+ */
unsigned Encoding::write_repeated_page_info(bitvec * dest, unsigned& wp,
uint8_t len,
uint8_t *identity, uint8_t chan_needed)
{
@@ -1078,7 +1092,7 @@
identity++;
len--;
} else {
- bitvec_write_field(dest, &wp,0x0,1); // MI
+ bitvec_write_field(dest, &wp,0x1,1); // MI
bitvec_write_field(dest, &wp,len,4); // MI len
}
while (len) {
--
To view, visit https://gerrit.osmocom.org/13133
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddb00b9133f523f4ba09c8f1fc5694e62dc46fbf
Gerrit-Change-Number: 13133
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Willmann <[email protected]>
Gerrit-Reviewer: Daniel Willmann <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Omar Ramadan <[email protected]>
Gerrit-CC: Pau Espin Pedrol <[email protected]>
