Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13121 )
Change subject: add osmo_use_count API ...................................................................... Patch Set 2: > > use a [0] sized array at the end of the counter > > I actually had exactly this scheme in an earlier version of this > patch, but I moved away from that, because: if we ever surpass the > use count we expected during development, the program would crash. > It would go fine for most of the time, just once in a while when N > events appear at the same time, boom. IMHO, you would simply check the size and refuse that additional transaction, no need to crash. -- To view, visit https://gerrit.osmocom.org/13121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife31e6798b4e728a23913179e346552a7dd338c0 Gerrit-Change-Number: 13121 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Thu, 07 Mar 2019 17:29:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
