Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13267 )
Change subject: pcu_sock: cast to long unsigned int before printing ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/13267/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13267/3//COMMIT_MSG@7 PS3, Line 7: pcu_sock: cast to long unsigned int before printing : : When using %lu and sizeof() for printing the compiler may throw a : warning. Lets prevent this by casting to long unsigned int. the commit log message doens't match at all what the code change is doning now. Please take care to make commit log messages match the code on subsequent edits. Thanks! -- To view, visit https://gerrit.osmocom.org/13267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5cb656537b1b73b9361a132801ab47ab7f8a709 Gerrit-Change-Number: 13267 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Daniel Willmann <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Comment-Date: Tue, 19 Mar 2019 13:07:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
