Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/13267 )

Change subject: pcu_sock: use %zu conversion specifier for printing sizeof() 
result
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/13267/4/src/common/pcu_sock.c
File src/common/pcu_sock.c:

https://gerrit.osmocom.org/#/c/13267/4/src/common/pcu_sock.c@794
PS4, Line 794:                  return 0;
Here too, memleak. Please Vadim either send a patch or otherwise tell me 
explicitly, I can do it in that case, np.



--
To view, visit https://gerrit.osmocom.org/13267
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5cb656537b1b73b9361a132801ab47ab7f8a709
Gerrit-Change-Number: 13267
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Daniel Willmann <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Comment-Date: Thu, 11 Apr 2019 16:46:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to