Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13259 )
Change subject: add gsm0808_create_handover_request_ack2 to add AoIP RTP addr ...................................................................... Patch Set 6: As I said: "because the use of sockaddr_storage isn't properly separated from implementations that get compiled on embedded and can't use it; embedded builds include headers naming struct sockaddr_storage even though the platform doesn't support it, and even function implementations using sockaddr_storage get compiled there but can't ever be used because they have unresolved references to functions handling sockaddr_storage" I cannot use struct sockaddr_storage in gsm0808.h, because some freaking .c files #include it also on ARM. I cannot #ifdef out in gsm0808.h, because obviously #include "config.h" doesn't work in a .h file installed in $prefix/include/. So the way headers get included need to be untangled. I don't really want to have to do that. Right now ARM only works because the .h defines an opaque struct sockaddr_storage and only uses pointers. Try it and you will see that ARM builds on jenkins fail. I would have liked to use the struct as non-pointer, but it's more work than anticipated. -- To view, visit https://gerrit.osmocom.org/13259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia71542ea37d4fd2c9fb9b40357db7aeb111ec576 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 6 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Sun, 24 Mar 2019 06:01:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
