Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13259 )
Change subject: add gsm0808_create_handover_request_ack2 to add AoIP RTP addr ...................................................................... Patch Set 8: Code-Review-1 I thin we have to keep this one out of master until the "embedded ARM builds" question is resolved. This is clearly in need of cleanup, and I really don't like us to make work around in APIs / runtime code just because some compile-time deicisons are not taken correctly. It may be time to simply disable lots of code that we'd never want to run inside a phone (like osmocombb) in the arm-non-eabi (EMBEDDED) builds. I'm not saying neels has to do this, I'm just saying it needs to happen. -- To view, visit https://gerrit.osmocom.org/13259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia71542ea37d4fd2c9fb9b40357db7aeb111ec576 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 8 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2019 07:41:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
