dexter has posted comments on this change. ( https://gerrit.osmocom.org/13340 )
Change subject: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT ...................................................................... Patch Set 3: (1 comment) > Patch Set 3: Code-Review+2 https://gerrit.osmocom.org/#/c/13340/2/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/#/c/13340/2/pySim/cards.py@540 PS2, Line 540: > You're overwriting the other sel_ctrl here, is that intended? […] During my tests it did not break anything. The 0004 makes the card placing a report of the file properties in the buffer, we can then use a GET RESPONSE command to fetch this data to figure out the file length. (in the old days of normal SIMs things were much easier, the length was returned by default along with some other parameters, also no TLV parsing was necessary) -- To view, visit https://gerrit.osmocom.org/13340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cac3041f1902383d98d6dc211cf31ae6e3a610b Gerrit-Change-Number: 13340 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Daniel Willmann <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Kévin Redon <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Tue, 26 Mar 2019 10:05:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
