Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13606 )
Change subject: ggsn.c: Refactor PCO processing during PDP activation ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/13606/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13606/1//COMMIT_MSG@9 PS1, Line 9: The existing PCO processing is implemented in a rater convoluted typo: rater https://gerrit.osmocom.org/#/c/13606/1/ggsn/ggsn.c File ggsn/ggsn.c: https://gerrit.osmocom.org/#/c/13606/1/ggsn/ggsn.c@606 PS1, Line 606: cur + sizeof(struct pco_element) <= pco->v + pco->l; Drop cur: for (pco_elem = (const struct pco_element *) co->v + 1; pco_elem + sizeof(*pco_elem) <= pco->v + pco->l; pco_elem = pco_elem + sizeof(*pco_elem) + pco_elem->length) { process_pco_element(pco_elem, resp, apn, pdp);} https://gerrit.osmocom.org/#/c/13606/1/ggsn/ggsn.c@620 PS1, Line 620: Extra line, remove it. -- To view, visit https://gerrit.osmocom.org/13606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a7d09279b6b259e2b95f1f51159b16838b2d94c Gerrit-Change-Number: 13606 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 11 Apr 2019 16:03:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
