Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13606 )
Change subject: ggsn.c: Refactor PCO processing during PDP activation ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13606/1/ggsn/ggsn.c File ggsn/ggsn.c: https://gerrit.osmocom.org/#/c/13606/1/ggsn/ggsn.c@606 PS1, Line 606: cur + sizeof(struct pco_element) <= pco->v + pco->l; > You actually need to cast to uint8_t* during the sum in last line most > probably I know that I can eliminate the local stack variable that way. However, I think it's more readable - and one doesn't have to have several in-line "const uint8_t *" typecasts to make the additions work. -- To view, visit https://gerrit.osmocom.org/13606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a7d09279b6b259e2b95f1f51159b16838b2d94c Gerrit-Change-Number: 13606 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 11 Apr 2019 17:39:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
