Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11194 )
Change subject: MNCC: Do not continue with B leg if A leg is cancelled. ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/11194/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/11194/1/src/mncc.c@383 PS1, Line 383: mncc_leg_release(leg); > This is kind of a workaround. […] I don't think it's a work-around but a fix. We shouldn't accept any messages that don't make sense in the current state. Still, there's also a bug on the sender side (MSC) if it sends those kind of messages after a DISC_IND. The proper use of FSMs on both sides would prevent any of this, IMHO. -- To view, visit https://gerrit.osmocom.org/11194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0eca9a741f7924c2fc32c503dd1a0fc083f94f37 Gerrit-Change-Number: 11194 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Comment-Date: Fri, 19 Apr 2019 06:31:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
