Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/11194 )
Change subject: MNCC: Do not continue with B leg if A leg is cancelled. ...................................................................... Patch Set 2: > @Keith: If you would have time to test it with your manual test > case, we could be 100% sure. Sure. It works as to be expected from static analysis: Basically you did the same thing (at least in the case where I handled it) Here's the log: DMNCC DEBUG <0001> mncc.c:866 MNCC rcvd message type: MNCC_SETUP_IND DMNCC DEBUG <0001> mncc.c:481 Created call(5004) with MNCC leg(2147483654) IMSI(262420312915730) DMNCC DEBUG <0001> mncc.c:68 Starting Timer for MNCC_RTP_CREATE DMNCC DEBUG <0001> mncc.c:866 MNCC rcvd message type: MNCC_DISC_IND DMNCC DEBUG <0001> mncc.c:526 Rcvd MNCC_DISC_IND, Cause: NORM_CALL_CLEAR DMNCC DEBUG <0001> mncc.c:528 leg(2147483654) was disconnected. Releasing DMNCC DEBUG <0001> mncc.c:68 Starting Timer for MNCC_REL_CNF DMNCC DEBUG <0001> mncc.c:142 MNCC sent message type: MNCC_REL_REQ DMNCC DEBUG <0001> mncc.c:866 MNCC rcvd message type: MNCC_RTP_CREATE DMNCC ERROR <0001> mncc.c:389 call(2147483654) can not be found DMNCC DEBUG <0001> mncc.c:142 MNCC sent message type: MNCC_REJ_REQ DMNCC DEBUG <0001> mncc.c:866 MNCC rcvd message type: MNCC_REL_CNF DMNCC DEBUG <0001> mncc.c:82 Got response(MNCC_REL_CNF), stopping timer on leg(2147483654) DMNCC DEBUG <0001> mncc.c:575 leg(2147483654) was cnf released. DAPP DEBUG <0002> call.c:88 call(5004) released. -- To view, visit https://gerrit.osmocom.org/11194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0eca9a741f7924c2fc32c503dd1a0fc083f94f37 Gerrit-Change-Number: 11194 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Reviewer: Rafael Diniz <[email protected]> Gerrit-Comment-Date: Sat, 20 Apr 2019 16:39:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
