Max has posted comments on this change. ( https://gerrit.osmocom.org/13629 )
Change subject: Introduce initial unit test for db_sms_* API ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13629/1/src/libmsc/db.c File src/libmsc/db.c: https://gerrit.osmocom.org/#/c/13629/1/src/libmsc/db.c@773 PS1, Line 773: if (net != NULL) /* db_sms_test passes NULL, so we need to be tolerant */ This can be split-off into separate patch. -- To view, visit https://gerrit.osmocom.org/13629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id94ad35b6f78f839137db2e17010fbf9b40111a3 Gerrit-Change-Number: 13629 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Max <sur...@alumni.ntnu.no> Gerrit-Comment-Date: Fri, 26 Apr 2019 11:10:02 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
