Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13629 )
Change subject: Introduce initial unit test for db_sms_* API ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/13629/2/src/libmsc/db.c File src/libmsc/db.c: https://gerrit.osmocom.org/#/c/13629/2/src/libmsc/db.c@776 PS2, Line 776: if (net != NULL) /* db_sms_test passes NULL, so we need to be tolerant */ if (net) https://gerrit.osmocom.org/#/c/13629/2/tests/db_sms/Makefile.am File tests/db_sms/Makefile.am: https://gerrit.osmocom.org/#/c/13629/2/tests/db_sms/Makefile.am@47 PS2, Line 47: -lrt \ Still not sure why is -lrt needed here. Did you try building without it? -- To view, visit https://gerrit.osmocom.org/13629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id94ad35b6f78f839137db2e17010fbf9b40111a3 Gerrit-Change-Number: 13629 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 08:29:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
