Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10983 )
Change subject: bts: CBCH related tests for OsmoBTS ...................................................................... Patch Set 4: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/10983/4/bts/BTS_Tests_SMSCB.ttcn File bts/BTS_Tests_SMSCB.ttcn: https://gerrit.osmocom.org/#/c/10983/4/bts/BTS_Tests_SMSCB.ttcn@158 PS4, Line 158: t_RslChanNr_CBCH(0) You should use the proper timeslot number here depending on pars.use_sdcch4. The same bug is present in OsmoBSC - it always does send CB Command on TS0. Also, please note that trxcon is using different RSL_CHAN_NR for both GSM_PCHAN_CCCH_SDCCH4_CBCH and GSM_PCHAN_SDCCH8_SACCH8C_CBCH, see https://git.osmocom.org/osmocom-bb/tree/src/host/trxcon/sched_trx.c#n529. I don't remember why I decided to have two different values. Most likely, because I wanted to be able do distinguish CCCH+SDCCH4+CBCH on TS0/C0 and SDCCH8+CBCH on TS0/CX. I hope this helps. -- To view, visit https://gerrit.osmocom.org/10983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I955b4000c12180a39b0205b69b7b2c8cee8c9da3 Gerrit-Change-Number: 10983 Gerrit-PatchSet: 4 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 20 May 2019 20:27:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
