Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10983 )
Change subject: bts: CBCH related tests for OsmoBTS ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/10983/4/bts/BTS_Tests_SMSCB.ttcn File bts/BTS_Tests_SMSCB.ttcn: https://gerrit.osmocom.org/#/c/10983/4/bts/BTS_Tests_SMSCB.ttcn@158 PS4, Line 158: t_RslChanNr_CBCH(0) > You should use the proper timeslot number here depending on pars.use_sdcch4. > […] as discussed on IRC, there's some lack of agreement on interpretation of channel numbers. I'll simply add a FIXME to the code for now and disable the SDCCH8 tests until this is resolved. -- To view, visit https://gerrit.osmocom.org/10983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I955b4000c12180a39b0205b69b7b2c8cee8c9da3 Gerrit-Change-Number: 10983 Gerrit-PatchSet: 4 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 20 May 2019 22:22:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
