Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/14196 )
Change subject: utils: add gsmtap_logread.py a gsmtap log reader ...................................................................... Patch Set 1: (5 comments) https://gerrit.osmocom.org/#/c/14196/1/utils/gsmtap.py File utils/gsmtap.py: https://gerrit.osmocom.org/#/c/14196/1/utils/gsmtap.py@64 PS1, Line 64: packformat = '!II16sIB3xxx16s32sI' That's actually headerformat and headerlen. Please change names of variables otherwise it's confusing. https://gerrit.osmocom.org/#/c/14196/1/utils/gsmtap_logread.py File utils/gsmtap_logread.py: https://gerrit.osmocom.org/#/c/14196/1/utils/gsmtap_logread.py@3 PS1, Line 3: # license: MIT do we want it to be MIT? https://gerrit.osmocom.org/#/c/14196/1/utils/gsmtap_logread.py@40 PS1, Line 40: You can drop this empty line. https://gerrit.osmocom.org/#/c/14196/1/utils/gsmtap_logread.py@61 PS1, Line 61: names = { This is constant yet python probably builds up the dictionary every time you call the function. May be worth moving it outside as static. https://gerrit.osmocom.org/#/c/14196/1/utils/gsmtap_logread.py@68 PS1, Line 68: if level in names: I think you can replace these 3 lines with: return names.get(level, "UNKNOWN") -- To view, visit https://gerrit.osmocom.org/14196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24478d8e16066c6118e867bdba54c6418c15e170 Gerrit-Change-Number: 14196 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 27 May 2019 08:43:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
