Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/14196 )

Change subject: utils: add gsmtap_logread.py a gsmtap log reader
......................................................................


Patch Set 1:

(1 comment)

deferring to Pau's technical comments

https://gerrit.osmocom.org/#/c/14196/1/utils/gsmtap_logread.py
File utils/gsmtap_logread.py:

https://gerrit.osmocom.org/#/c/14196/1/utils/gsmtap_logread.py@3
PS1, Line 3: # license: MIT
> do we want it to be MIT?
It's unusual for Osmocom, but for such a "small external utility" I won't 
insist on copyleft. Also, it doesn't state sysmocom as copyright holder, so I 
assume it's written in spare time and hence lynxis gets to  decide.  Might be 
good to use a SPDX-Identifier right away.



--
To view, visit https://gerrit.osmocom.org/14196
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I24478d8e16066c6118e867bdba54c6418c15e170
Gerrit-Change-Number: 14196
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-CC: Harald Welte <[email protected]>
Gerrit-CC: Pau Espin Pedrol <[email protected]>
Gerrit-Comment-Date: Mon, 27 May 2019 13:33:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to