laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14402 )
Change subject: hlr: add Check IMEI tests ...................................................................... Patch Set 1: Code-Review-1 (2 comments) -1 for not using f_vty_config. The other comment is optional. https://gerrit.osmocom.org/#/c/14402/1/hlr/HLR_Tests.ttcn File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/#/c/14402/1/hlr/HLR_Tests.ttcn@364 PS1, Line 364: f_vty_transceive(VTY, "configure terminal"); : f_vty_transceive(VTY, "hlr"); : if (enable) { : f_vty_transceive(VTY, "store-imei"); : } else { : f_vty_transceive(VTY, "no store-imei"); : } we do have elegant helper functions for this, see f_vty_config() for simple cases in the root node, and f_vty_config2() which traverses a path. See examples in BTS_Tests.ttcn and MSC_Tests.ttcn https://gerrit.osmocom.org/#/c/14402/1/hlr/HLR_Tests.ttcn@602 PS1, Line 602: setverdict(fail, "Unexpected CHECK IMEI ERROR Cause"); if you have the data aleady in 'ret', it might be useful to append it to the setverdict statement like "setverdict(fail, "Unexpected ....", ret)" and hence give more context to the [human] reader of a log output. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I97c8462f0817149feadd0c4865e3df6c2af92a80 Gerrit-Change-Number: 14402 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Sat, 08 Jun 2019 10:05:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
