osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14402 )
Change subject: hlr: add Check IMEI tests ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/14402/1/hlr/HLR_Tests.ttcn File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/#/c/14402/1/hlr/HLR_Tests.ttcn@364 PS1, Line 364: f_vty_transceive(VTY, "configure terminal"); : f_vty_transceive(VTY, "hlr"); : if (enable) { : f_vty_transceive(VTY, "store-imei"); : } else { : f_vty_transceive(VTY, "no store-imei"); : } > we do have elegant helper functions for this, see f_vty_config() for simple > cases in the root node, […] Done https://gerrit.osmocom.org/#/c/14402/1/hlr/HLR_Tests.ttcn@602 PS1, Line 602: setverdict(fail, "Unexpected CHECK IMEI ERROR Cause"); > if you have the data aleady in 'ret', it might be useful to append it to the > setverdict statement li […] Done https://gerrit.osmocom.org/#/c/14402/1/hlr/HLR_Tests.ttcn@1175 PS1, Line 1175: res > So you return GSUP_PDU, but never use it? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I97c8462f0817149feadd0c4865e3df6c2af92a80 Gerrit-Change-Number: 14402 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jun 2019 07:32:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilira...@gmail.com> Comment-In-Reply-To: laforge <lafo...@gnumonks.org> Gerrit-MessageType: comment