laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14439 )
Change subject: logging: introduce LOG_BTS and LOG_TRX and use it everywhere ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14439/2/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/14439/2/src/osmo-bsc/abis_nm.c@1704 PS2, Line 1704: int abis_nm_get_attr(struct gsm_bts *bts, uint8_t obj_class, uint8_t bts_nr, uint8_t trx_nr, uint8_t ts_nr, > Looks like we should be passing here "struct gsm_bts_trx *trx" instead of > "bts" + "trx_nr". […] bts->nr != the Abis OML BTS number! bts->nr relates to the logical BTS number inside the entire BSC scope, wherease the OML MO BTS number refers to the BTS in that given OML link. A site will typically have three BTSs, so there's always 0,1,2 at a three-sector setup. In Abis/IP you will have separate TCP/IPA connections for those, where each BTS is OML MO BTS Number 0. In [reasonable] E1 sestups, you will only have a single E1 signaling timeslot with ML MO BTS Number 0/1/2. https://gerrit.osmocom.org/#/c/14439/2/src/osmo-bsc/acc_ramp.c File src/osmo-bsc/acc_ramp.c: https://gerrit.osmocom.org/#/c/14439/2/src/osmo-bsc/acc_ramp.c@170 PS2, Line 170: if (trx->nr != 0) > If we only care about first TRX, I'm not sure it makes sense to use LOG_TRX > in this function and use […] I agree. However, this patch is merely a "mechanical" change from the existing code to new code. Even the existing code is logging (bts=%d,trx=%d) so I keep it that way, without introducing more changes than needed in this one patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4a7814d164384eecfb6913c31802cf2faead6e6c Gerrit-Change-Number: 14439 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2019 15:55:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
