pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14439 )
Change subject: logging: introduce LOG_BTS and LOG_TRX and use it everywhere ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14439/2/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/14439/2/src/osmo-bsc/abis_nm.c@1704 PS2, Line 1704: int abis_nm_get_attr(struct gsm_bts *bts, uint8_t obj_class, uint8_t bts_nr, uint8_t trx_nr, uint8_t ts_nr, > bts->nr != the Abis OML BTS number! […] Thanks, very instructive. https://gerrit.osmocom.org/#/c/14439/2/src/osmo-bsc/acc_ramp.c File src/osmo-bsc/acc_ramp.c: https://gerrit.osmocom.org/#/c/14439/2/src/osmo-bsc/acc_ramp.c@170 PS2, Line 170: if (trx->nr != 0) > I agree. However, this patch is merely a "mechanical" change from the > existing code to new code. […] Fine, but you are already changing BTS->TRX in some lines in this function, so I think it actually makes sense to change the other ones in TRX->BTS direction ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4a7814d164384eecfb6913c31802cf2faead6e6c Gerrit-Change-Number: 14439 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2019 15:59:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
