pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 )
Change subject: Introduce structs to encode TRXD packets ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14629/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/14629/1/Transceiver52M/Transceiver.cpp@967 PS1, Line 967: pkt->soft_bits[nbits] = '\0'; Here I actually introduced a change, and to me wrong version looks "wrong", since it's leaving one byte (burstString[nbits+8]) uninitialized. Not sure why do we do that jump and why do we actually add a trailing whitespace there in burstString[nbits + 9]. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb Gerrit-Change-Number: 14629 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 28 Jun 2019 15:30:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
