pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 )
Change subject: Introduce structs to encode TRXD packets ...................................................................... Patch Set 2: > Patch Set 2: > > Also, it would be great to split TRX protocol implementation out of > Transceiver.cpp. Agree, I plan to do that in forthcoming commit once we implement different versions, I didn't want to make too many changes atthe same time, it'd have been confusing. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb Gerrit-Change-Number: 14629 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 01 Jul 2019 09:48:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
