osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14589 )
Change subject: mgw: Support uppercase LCO options ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/14589/1/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/#/c/14589/1/src/libosmo-mgcp/mgcp_protocol.c@612 PS1, Line 612: while ((lco_id = get_lco_identifier(lco_id))) { This is changing the parsing logic slightly. It is probably worth mentioning in the commit message, just in case we have a regression. Here's an example where the result would not be the same (probably not a real world use case; old code uses first p:, new code uses second p:): p:1234-1234, a:PCUM, p:2345-2345 https://gerrit.osmocom.org/#/c/14589/1/src/libosmo-mgcp/mgcp_protocol.c@630 PS1, Line 630: "LCO: unhandled option: '%c'/%d\n", *lco_id, *lco_id); How about also logging the entire lco->string here? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic28a5eacc4c441d68e8a20d2743956ab2e01125d Gerrit-Change-Number: 14589 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 03 Jul 2019 07:18:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
