pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/14589 )

Change subject: mgw: Support uppercase LCO options
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14589/1/src/libosmo-mgcp/mgcp_protocol.c
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/#/c/14589/1/src/libosmo-mgcp/mgcp_protocol.c@612
PS1, Line 612:  while ((lco_id = get_lco_identifier(lco_id))) {
> After reading https://gerrit.osmocom. […]
Yes, check_local_cx_options() takes care of it so that scenario cannot happen.



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14589
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic28a5eacc4c441d68e8a20d2743956ab2e01125d
Gerrit-Change-Number: 14589
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillm...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@gnumonks.org>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Jul 2019 10:37:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osm...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to