pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14657 )
Change subject: Transceiver: Support TRXD v1 ...................................................................... Patch Set 6: (2 comments) This change is ready for review. https://gerrit.osmocom.org/#/c/14657/5/Transceiver52M/proto_trxd.h File Transceiver52M/proto_trxd.h: https://gerrit.osmocom.org/#/c/14657/5/Transceiver52M/proto_trxd.h@17 PS5, Line 17: Not supported yet > Neither OsmoTRX will support them any time soon. Sure, I just wanted to list them here since they are also described in the protocol header. https://gerrit.osmocom.org/#/c/14657/2/Transceiver52M/proto_trxd.c File Transceiver52M/proto_trxd.c: https://gerrit.osmocom.org/#/c/14657/2/Transceiver52M/proto_trxd.c@68 PS2, Line 68: pkt->common.version = 1; : pkt->common.reserved = 0; : pkt->common.tn = bi->tn; : osmo_store32be(bi->fn, &pkt->common.fn); : pkt->v1.rssi = bi->rssi; : osmo_store16be(toa_int, &pkt->v1.toa); > This basically duplicates what trxd_send_burst_ind_v0() does. […] I don't think it's really a benefit moving it, since anyway one still needs to set version bit differently for instance. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 04 Jul 2019 14:45:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
