laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/14657 )

Change subject: Transceiver: Support TRXD v1
......................................................................


Patch Set 9: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/14657/9/Transceiver52M/Transceiver.cpp
File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/#/c/14657/9/Transceiver52M/Transceiver.cpp@622
PS9, Line 622: bi->tss = 0;
> I just checked 3GPP TS 45.002, tables 5.2.3a-d. […]
might make sense to have a comment (or even an enum)



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517
Gerrit-Change-Number: 14657
Gerrit-PatchSet: 9
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Comment-Date: Sun, 14 Jul 2019 04:18:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to