laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 )
Change subject: log_merge.sh: format logs after merging ...................................................................... Patch Set 1: -Code-Review this basically means we cannot use any other tools on the logs but only use them for human consumption. Admittedly, this is the common case for now - but there are other tools such as the TITAN Eclipse Log file analyzer as well as the ttcn3_logfilter, which AFAIK all work only on the "un-formatted" log with one line per log event. So there's a trade-off here: Do we really want to preclude any such other tools (even future tools that we many not know yet or that many not exist yet) by unconditionally calling logformat? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I671ffa2761c6e503dae9f3b16764d430131b16af Gerrit-Change-Number: 14707 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Wed, 10 Jul 2019 01:53:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
