laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 )

Change subject: log_merge.sh: format logs after merging
......................................................................


Patch Set 2: Code-Review-1

I don't think it's good to double the size of our build artefacts without any 
good reason.  Having to type "ttcn3_logformat foo.log | less" vs. typing "less 
foo.log" does not sound like a "good reason" to me, sorry.  I'm happy to align 
with what the majority of the developers thinks, but to me it doesn't really 
seem to offer much gain.


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I671ffa2761c6e503dae9f3b16764d430131b16af
Gerrit-Change-Number: 14707
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Comment-Date: Thu, 11 Jul 2019 03:46:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to