fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14876 )
Change subject: scheduler_trx: Deal with osmo_amr_rtp_enc() returning negative ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/14876/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14876/1/src/osmo-bts-trx/scheduler_trx.c@1241 PS1, Line 1241: tch_data This change solves the problem of passing a negative number to memset(). But accessing uninitialized memory is still possible. Just an idea for follow-up changes. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14876 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I70ce98c5697b9ce6fac7ab57a5d70f3201db29d9 Gerrit-Change-Number: 14876 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Comment-Date: Sun, 21 Jul 2019 11:16:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
