fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 )
Change subject: common: trx_if.adoc: Improve documentation ...................................................................... Patch Set 4: Code-Review-1 (6 comments) https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc@5 PS4, Line 5: The s/The/the/ https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc@162 PS4, Line 162: 48-55: TOA256 ToA256 actually takes 2 octets. https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc@163 PS4, Line 163: 56-95: where does this range come from? https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc@184 PS4, Line 184: TOA256: 8 bits (1 byte):: same here https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc@208 PS4, Line 208: RSSI It's called PWR. https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc@226 PS4, Line 226: RSSI: 8 bits (1 byte):: : Received Signal Strength Indication in -dBm, encoded without the negative sign. And AFAIR, it indicates Tx power attenuation wrt. the full scale. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 25 Jul 2019 17:16:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
